Ebook processing retries corrupt or unsupported files 3 times #22

New issue

Open

opened 2026-10-18 16:23:37 +00:00 by jfro · 0 comments

jfro commented

2026-10-18 16:23:37 +00:00

Owner

From Nye's review of #17 (F2).

ProcessWorker returns {:error, reason} for corrupt or unsupported files, so Oban retries the job 3 times and re-hashes the file every time. These errors aren't transient.

Fix: return {:cancel, reason} (after marking the ebook failed) for non-transient errors such as parse failures and unsupported formats; keep {:error, _} for transient ones (DB, file temporarily unreadable).

From Nye's review of #17 (F2). `ProcessWorker` returns `{:error, reason}` for corrupt or unsupported files, so Oban retries the job 3 times and re-hashes the file every time. These errors aren't transient. **Fix:** return `{:cancel, reason}` (after marking the ebook failed) for non-transient errors such as parse failures and unsupported formats; keep `{:error, _}` for transient ones (DB, file temporarily unreadable).

jfro added the

ebook-branch

low

bug

labels

2026-10-18 16:23:37 +00:00